On Mon, 3 Jun 2013, Stephen Warren wrote: > From: Manjunath Goudar <manjunath.goudar@xxxxxxxxxx> > > Some EHCI HCD drivers may need to override additional fields in struct > hc_driver, such as map_urb_for_dma, unmap_urb_for_dma, hub_control. Add > fields to struct ehci_driver_overrides to allow them to do so. > > These new overrides will be used at least by the Tegra EHCI driver. This is not a good approach. ehci-tegra is the only driver that needs to muck around with these things, so they should not be part of a standardized override structure. Indeed, so strong is my feeling that platforms shouldn't have to do this sort of thing that I want to make it difficult, not easy. Instead of adding extra fields to ehci_driver_overrides, let's force ehci-tegra to manually insert its own values into the tegra_ehci_hc_driver structure. Then this patch won't be necessary at all. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
