Re: [PATCH 09/12] tegra20-apb-dma: remove useless use of lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 27 May 2013 05:44 PM, Andy Shevchenko wrote:
Accordingly to dma_cookie_status() description locking is not required.

I think we need lock here:
From isr handler, we call dma_cookie_complete() which is in spin-locked. This function updates tx->chan->completed_cookie = tx->cookie; In tegra_dma_tx_status(), we check for dma_cookie_status() which access the chan->completed_cookie; and it decides status based on this

As the access of chan->completed_cookie are from different context, we need this locking.

But did not get why it is documented as locking is not require if shared variable is getting changed/access from different context simultaneously.

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux