On 05/08/2013 03:40 AM, Peter De Schrijver wrote: > On Tue, May 07, 2013 at 04:54:31PM +0200, Stephen Warren wrote: >> On 05/07/2013 07:08 AM, Thierry Reding wrote: >>> On Tue, May 07, 2013 at 03:48:49PM +0300, Peter De Schrijver >>> wrote: >>>> On Mon, May 06, 2013 at 10:39:04PM +0200, Stephen Warren wrote: >>>>> From: Stephen Warren <swarren@xxxxxxxxxx> >>>>> >>>>> Tegra20 HW appears to have a bug such that PCIe device >>>>> interrupts, whether they are legacy IRQs or MSI, are lost when >>>>> LP2 is enabled. To work around this, simply disable LP2 if the >>>>> PCI driver and DT node are both enabled. >>>>> >>>> >>>> Wouldn't it make more sense to disable LP2 when we actually >>>> detect a PCIe device? >> >> I did consider that, but rejected the idea for the reasons Thierry >> mentioned. ... >>> Furthermore, it is quite likely that the PCIe controller will only >>> be enabled in DT for devices that actually have a PCIe device >>> hooked up. > > That's not always true though. Eg Harmony has a miniPCIe slot, so it should be > listed in DT, but there is not necessarily a card present in the slot. I initially thought that this issue only affected Tegra20, so I was prepared to ignore the lack of optimality of this solution, since it only affects Harmony. However, initial experimentation with Jay's Tegra30 PCIe patches imply the same issue is present on Tegra30. I need to do more research to confirm whether it's the same problem or something else though. If this turns out to be true, we'll have to come up with a more complex solution, since this current solution would disable LP2 outright on all currently supported Tegra30 boards:-( -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
