On 04/08/2013 09:41 AM, Jay Agarwal wrote: > Signed-off-by: Jay Agarwal <jagarwal@xxxxxxxxxx> Your s-o-b line should be below the patch description, not above it. Please see Documentation/SubmittingPatches. I also don't see a --- line between the patch description and diffstat. How are you generating these patch emails? Please see our internal wiki, or other git documentation. > diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi > - clock-names = "pex", "afi", "pcie_xclk", "pll_e", "cml"; > + clock-names = "pex", "afi", "pcie_xclk", "pll_e", "cml0"; Can you please explain more about this change? I see the Tegra clock driver provides both a "cml0" and a "cml1" clock. Are both of those used for PCIe? If so, then why doesn't the driver and this DT change include both cml0 and cml1? If not, then please note that the clock-names property doesn't have to match the name of the clock at the clock provider. This property names the clock inputs to the HW module. Hence, if the PCIe module only uses a single CML clock, it can quite legitimately name its clock input just "cml" rather than "cml0". In this case, you wouldn't need to make this change to the DT. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
