On Thu, Mar 21, 2013 at 3:30 PM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote: > #ifdef CONFIG_OF_GPIO > - palmas_gpio->gpio_chip.of_node = palmas->dev->of_node; > + palmas_gpio->gpio_chip.of_node = pdev->dev.of_node; > #endif OK I think that #ifdef is necessary... > +#ifdef CONFIG_OF > +static struct of_device_id of_palmas_gpio_match[] = { > + { .compatible = "ti,palmas-gpio"}, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, of_palmas_gpio_match); > +#endif But please drop the #ifdef here unless it causes compile errors (I don't think it will.) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html