On Wed, Mar 20, 2013 at 05:47:46PM +0530, Venu Byravarasu wrote: > > -----Original Message----- > > From: kishon [mailto:kishon@xxxxxx] > > Sent: Wednesday, March 20, 2013 4:53 PM > > To: Venu Byravarasu > > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; stern@xxxxxxxxxxxxxxxxxxx; > > balbi@xxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > swarren@xxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; devicetree- > > discuss@xxxxxxxxxxxxxxxx > > Subject: Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding > > rework > > > > Hi, > > > > On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote: > > > This patch updates all Tegra board files so that they contain all the > > > properties required by the updated USB DT binding. Note that this patch > > > only adds the new properties and does not yet remove the old properties, > > > in order to maintain bisectability. The old properties will be removed > > > once the driver has been updated to assume the new bindings. > > > > > > Signed-off-by: Venu Byravarasu <vbyravarasu@xxxxxxxxxx> > > > --- > > > arch/arm/boot/dts/tegra20-colibri-512.dtsi | 4 +++ > > > arch/arm/boot/dts/tegra20-harmony.dts | 8 +++--- > > > arch/arm/boot/dts/tegra20-iris-512.dts | 4 +++ > > > arch/arm/boot/dts/tegra20-paz00.dts | 8 +++--- > > > arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++++++--- > > > arch/arm/boot/dts/tegra20-trimslice.dts | 12 +++++++--- > > > arch/arm/boot/dts/tegra20-ventana.dts | 7 +++-- > > > arch/arm/boot/dts/tegra20.dtsi | 32 +++++++++++++++++---------- > > > 8 files changed, 57 insertions(+), 31 deletions(-) > > > > > > diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi > > b/arch/arm/boot/dts/tegra20-colibri-512.dtsi > > > index cb73e62..af5a7ae 100644 > > > --- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi > > > +++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi > > > @@ -443,6 +443,10 @@ > > > nvidia,phy-reset-gpio = <&gpio 169 0>; /* gpio PV1 */ > > > }; > > > > > > + usb-phy@c5004000 { > > This node doesn't have a *reg* property. So "@c5004000" is not needed. > > This comment applies to all the nodes which doesn't have *reg* property. > > Thanks Kishon for the comments. > As I've 3 usb-phy DT nodes, how to differentiate between them if I remove this @Address ? then add reg property :-) -- balbi
Attachment:
signature.asc
Description: Digital signature
