On 03/13/2013 03:48 AM, Danny Huang wrote: > Expose Tegra chip ID and revision in /sys/devices/soc for user mode > usage > diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c > static void __init tegra_dt_init(void) > { > + struct device *parent = NULL; > + struct soc_device *soc_dev; > + struct soc_device_attribute *soc_dev_attr; Since Russell asked you to redo the patch anyway, I'd prefer that variables be declared in the order they're used. So, soc_dev_attr, then soc_dev, then parent. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html