On 03/11/2013 01:29 PM, Laxman Dewangan wrote:
> On Monday 11 March 2013 10:46 PM, Stephen Warren wrote:
>> On 03/09/2013 11:09 AM, Laxman Dewangan wrote:
>>> Use macro module_platform_driver_probe() to reduce some of the
>>> boilerplate code in the driver.
>>> diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c
>>> -static int __init tegra_rtc_init(void)
>>> -{
>>> - return platform_driver_probe(&tegra_rtc_driver, tegra_rtc_probe);
>>> -}
>>> -module_init(tegra_rtc_init);
>>> -
>>> -static void __exit tegra_rtc_exit(void)
>>> -{
>>> - platform_driver_unregister(&tegra_rtc_driver);
>>> -}
>>> -module_exit(tegra_rtc_exit);
>>> +module_platform_driver_probe(tegra_rtc_driver, tegra_rtc_probe);
>>
>> Out of curiosity here, why not just module_platform_driver(); can't the
>> instantiation of the RTC device be driven by the presence of the DT
>> node, and hence the creation of the platform device object, just like
>> any other driver/device?
>
> Theoretically it should work but I will work with John (original author)
> about using the platform_driver_probe().
> If he agrees then I will send patch to convert it to
> module_platform_driver().
OK, sounds good. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
