On Fri, 22 Feb 2013 16:02:28 +0100 Peter De Schrijver <pdeschrijver@xxxxxxxxxx> wrote: > Add a table lookup feature to the mux clock. Also allow arbitrary masks > instead of the width. This will be used by some clocks on Tegra114. > > Signed-off-by: Peter De Schrijver <pdeschrijver@xxxxxxxxxx> .... > @@ -42,7 +43,17 @@ static u8 clk_mux_get_parent(struct clk_hw *hw) > * val = 0x4 really means "bit 2, index starts at bit 0" > */ .... > + if (mux->table) { > + int i; > + > + for (i = 0; i < num_parents; i++) > + if (mux->table[i] == val) > + return i; > + if (i == num_parents) > + return -EINVAL; > + } Can't we just return after for-loop without checking i == num_parents as below? + for (i = 0; i < num_parents; i++) { + if (mux->table[i] == val) + return i; + } + + return -EINVAL; -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html