On Fri, 2013-02-22 at 21:05 +0800, Peter De Schrijver wrote: > On Fri, Feb 22, 2013 at 07:44:48AM +0100, Joseph Lo wrote: > > The Tegra kernel only support boot from DT now. Clean up the PMC driver > > to support DT only, that includes: > > > > * remove the ifdef of CONFIG_OF > > * replace the static mapping of PMC addr to map from DT > > > > -#ifdef CONFIG_OF > > static const struct of_device_id matches[] __initconst = { > > { .compatible = "nvidia,tegra20-pmc" }, > > { } > > At least an extra entry for tegra114-pmc is necessary here. tegra114.dtsi only > has: > > pmc { > compatible = "nvidia,tegra114-pmc", "nvidia,tegra30-pmc"; > reg = <0x7000e400 0x400>; > }; > I think it should be something like below, isn't it? compatible = "nvidia,tegra114-pmc", "nvidia,tegra30-pmc", "nvidia,tegra20-pmc"; or should we add tegra114 and tegra30 in the DT match table? Thanks, Joseph -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html