On Mon, Feb 18, 2013 at 02:17:53PM +0800, Mark Zhang wrote:
> On 02/14/2013 12:05 AM, Thierry Reding wrote:
> > The sequence for replacing the scanout buffer is much shorter than a
> > full mode change operation so implementing this callback considerably
> > speeds up cases where only a new framebuffer is to be scanned out.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
> > ---
> > Changes in v3:
> > - split DC_CMD_STATE_CONTROL writes
> >
> > drivers/gpu/drm/tegra/dc.c | 31 +++++++++++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
> > index 8f97b1c..cc4c85e 100644
> > --- a/drivers/gpu/drm/tegra/dc.c
> > +++ b/drivers/gpu/drm/tegra/dc.c
> > @@ -114,6 +114,27 @@ static int tegra_dc_add_planes(struct drm_device *drm, struct tegra_dc *dc)
> > return 0;
> > }
> >
> > +static int tegra_dc_set_base(struct tegra_dc *dc, int x, int y,
> > + struct tegra_framebuffer *fb)
> > +{
> > + unsigned long value;
> > +
> > + tegra_dc_writel(dc, WINDOW_A_SELECT, DC_CMD_DISPLAY_WINDOW_HEADER);
> > +
> > + value = fb->base.offsets[0] + y * fb->base.pitches[0] +
> > + x * fb->base.bits_per_pixel / 8;
> > +
> > + tegra_dc_writel(dc, fb->obj->paddr + value, DC_WINBUF_START_ADDR);
> > +
> > + value = GENERAL_UPDATE | WIN_A_UPDATE;
> > + tegra_dc_writel(dc, value, DC_CMD_STATE_CONTROL);
> > +
> > + value = GENERAL_ACT_REQ | WIN_A_ACT_REQ;
> > + tegra_dc_writel(dc, value, DC_CMD_STATE_CONTROL);
> > +
> > + return 0;
> > +}
>
> Again, what do you think about the "line stride" problem I mentioned:
>
> http://lists.freedesktop.org/archives/dri-devel/2013-January/033561.html
>
> Don't get me wrong that I also don't want to add a line stride update
> here because that doesn't make sense. It's just a workaround. But we
> need to find a way to make multi-head page flip working.
I'm not sure that it's something we need to support. .mode_set_base() is
explicitly used only for cases where the framebuffer configuration
doesn't change. That is, only in cases where the only thing that changes
is the physical address of the framebuffer to be displayed.
The current case where one framebuffer is used as scanout for both
outputs isn't something that page-flipping can support. Page-flipping is
always per-CRTC because typically each CRTC would run at a different
frequency (or even if both ran at the same frequency the VBLANK is very
unlikely to coincide anyway).
So an application that wants to support page-flipping on two outputs
also needs to take care to set them up with different framebuffers, in
which case what you're describing here can't really happen.
Thierry
Attachment:
pgpglFOdyPr51.pgp
Description: PGP signature
