On Jan 16, 2013, at 9:37 PM, Colin Cross <ccross@xxxxxxxxxxx> wrote: > On Wed, Jan 16, 2013 at 6:07 PM, Jeremy Andrus <jeremya@xxxxxxxxxxxxxxx> wrote: >> On Jan 16, 2013, at 4:45 PM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: >> >>> On 01/16/2013 12:56 PM, Jeremy C. Andrus wrote: >>>> From: "Jeremy C. Andrus" <jeremya@xxxxxxxxxxxxxxx> >>>> >>>> In the course of my research here at Columbia University, I have been >>>> doing some kernel development on the Google Nexus 7 device. I took the >>>> time to address most of the compile-time warnings while building the >>>> Tegra kernel tree using the cross-compiler shipped with Android >>>> (gcc-4.7), and in doing so I came across a few minor issues. >>>> >>>> This RFC series addresses several minor bugs that I was able to fix >>>> while suppressing compile warnings. Not knowing exactly where >>>> to send the patches, I decided to send them primarily to the Tegra >>>> list serv in hopes that they will find their way to the correct place. >>>> >>>> All 5 patches apply cleanly the kernel/tegra repository hosted by >>>> Google. I used the commit hash referenced in the Android device tree >>>> git logs as my HEAD revision: 22b4fcde206e96f57bf0a111403fc3d75532918a >>>> I belive that this is the revision which corresponds to the prebuilt >>>> kernel provided in the Jelly Bean release. >>> >>> I honestly don't know where you should send these patches. I've CC'd >>> Colin Cross who works on Android in case he can clue us in. I assume >>> there's a Gerrit instance somewhere for Android that you need to push >>> these into... >>> >>> Laxman, can you please check if any of these patches should be applied >>> to our internal/downstream kernels? >> >> The first patch actually fixed my build! When using the prebuilt toolchains >> provided by google (as per Android build instructions), the build failed on >> arch/arm/mach-tegra/sleep.S. This seems to be because the Makefile >> function $(call as-instr,…) didn't function properly. I would think that some >> sort of fix to make the Tegra tree build-able using Android toolchains >> would be appropriate here... > > I don't think this has anything to do with Android except that the > toolchain shipped with Android moved to a newer version of binutils. > The as-instr in the Makefile should work fine and I believe is the > preferable solution over adding the arch_extension to sleep.S, maybe > it has a typo? I can take a look. I would agree that a Makefile solution slightly more clean. Unfortunately, the tree available from Google which corresponds to the Jelly Bean release won't build with the Android toolchain. I tried both the gcc-4.6 and gcc-4.7 prebuilts. It seems like the define in the file isn't a horrible solution though - the code obviously requires the extension... >>> Jeremy, do patches 3 or 4 need to be applied to the mainline kernel? It >>> may be useful for you to resend those directly to the relevant upstream >>> subsystem maintainers, after rebasing them onto the latest upstream >>> code. See Documentation/SubmittingPatches in the mainline kernel. >> >> OK. I will send those patches out to subsystem maintainers (assuming that >> they are not already fixed). >> >>> Thanks for the contributions! >> >> >> You're welcome! This was my first experience with git-format-patch, and >> it was kind of fun to re-contribute in a small way. >> >> I actually have another set of patches that fix all the build warnings. Is >> there a repo / branch that I should rebase these on and then send them >> out? It was definitely worth the effort to eliminate all the warnings - it >> made it a lot easier to spot my own mistakes :-) >> >> Best, >> >> -Jeremy >> -- -------------------------------------------------- Jeremy C. Andrus e: jchristian.andrus@xxxxxxxxx w: http://jeremya.com/ l: New York, NY p: 616,439,0522 -------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
