[RFC PATCH 4/5] input: lid: Fix init function ignores sysfs retval

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Jeremy C. Andrus" <jeremya@xxxxxxxxxxxxxxx>

Don't ignore the sysfs_create_group return value in the lid_init()
function. This suppresses a compiler warning and results in more robust
code for free :-)

Signed-off-by: Jeremy C. Andrus <jeremya@xxxxxxxxxxxxxxx>

Change-Id: I2fef38736d39fbd5f60ef5a658f14d917122b942
Cc: Stephen Warren <swarren@xxxxxxxxxxxxx>
Cc: Olof Johansson <olof@xxxxxxxxx>
---
 drivers/input/lid.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/input/lid.c b/drivers/input/lid.c
index 1d27609..26e3d64 100644
--- a/drivers/input/lid.c
+++ b/drivers/input/lid.c
@@ -163,7 +163,9 @@ static int __init lid_init(void)
                 return -ENOMEM;
         }
 
-	sysfs_create_group((struct kobject*)&lid_dev->dev.kobj, &lid_attr_group);
+	err_code = sysfs_create_group((struct kobject*)&lid_dev->dev.kobj, &lid_attr_group);
+	if (err_code != 0)
+		return err_code;
 
 	err_code = lid_input_device_create();
 	if(err_code != 0)
-- 
1.8.1

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux