On Tue, Jan 15, 2013 at 06:53:19PM +0100, Daniel Vetter wrote:
> On Mon, Jan 14, 2013 at 4:55 PM, Thierry Reding
> <thierry.reding@xxxxxxxxxxxxxxxxx> wrote:
> > +static void tegra_drm_preclose(struct drm_device *drm, struct drm_file *file)
> > +{
> > + struct drm_crtc *crtc;
> > +
> > + list_for_each_entry(crtc, &drm->mode_config.crtc_list, head)
> > + tegra_dc_cancel_page_flip(crtc, file);
> > +}
> > +
>
> Why that? If userspace dies while a flip is outstanding, it's imo ok
> to execute it - otherwise there might be an accounting mismatch if the
> hw still scans out the old fb, but drm believes the new one is used.
> Or do I miss something?
I looked at the shmobile driver for inspiration and they do this as
well. Doing so seemed reasonable since there'd be no file to deliver the
event to.
> The reason I've skimmed through the patches is to check for
> implications with my modeset locking rework. Review on that would be
> highly appreciated ...
I'm not sure how suited I am for review given my limited experience, but
I'll see if I can make some time to take a look.
Thierry
Attachment:
pgp8UVuBAtrA1.pgp
Description: PGP signature
