Re: [PATCH 1/2] ARM: DT: tegra: Add Tegra30 Beaver board support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/28/2012 08:43 PM, Olof Johansson wrote:
On Fri, Dec 28, 2012 at 3:54 PM, Stephen Warren <swarren@xxxxxxxxxx> wrote:
On 12/28/2012 09:22 AM, Rob Herring wrote:
On 12/20/2012 01:41 PM, Bryan Wu wrote:
This patch adds support for Tegra30 Beaver board in upstream kernel.
diff --git a/arch/arm/boot/dts/tegra30-beaver.dts b/arch/arm/boot/dts/tegra30-beaver.dts
+/ {
+    model = "NVIDIA Tegra30 Beaver evaluation board";
+    compatible = "nvidia,beaver", "nvidia,tegra30";
nvidia,beaver needs to be documented.
Hmmm. I guess we've managed not to document /any/ of the Tegra
board-level compatible values. Bryan, could you make a separate patch to
add all the existing board compatible values to
Documentation/devicetree/bindings/arm/tegra.txt. The Beaver addition to
that file can still be part of the Beaver-specific patch though.
Does it need to be documented? Then the "support a new platform only
through DTS update" is no longer true. :)

In the past, I don't think we've strictly documented all derivative
platform compatible values, just some of the reference ones?


-Olof

Actually in every Tegra board dts file, there is a model string to describe this machine as well as a compatible board string, just like the "nvidia,beaver". So do we still need put this duplicated information in a document file? Or if this is the requirement of DeviceTree. I will do that. I think we have 12 boards need to add such document currently.

Thanks and happy new year.
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux