On Sun, Dec 23, 2012 at 6:35 PM, Prashant Gaikwad <pgaikwad@xxxxxxxxxx> wrote: > On Saturday 22 December 2012 02:57 AM, Stephen Warren wrote: >> >> On 12/21/2012 03:09 AM, Richard Zhao wrote: >>> >>> tegra_cpu_init/exit will be called every time one cpu core is online or >>> offline. And all cpu cores share same clocks, redundant clk_get/put >>> wast time, so I move them out. >> >> I think this is reasonable. >> >> Prashant, Peter, any comments? >> >> Is any other work in tegra_cpu_init() redundant? Is tegra_cpu_init() >> supposed to be called due to hotplug, or is that a bug in the cpufreq >> core? When cpu goes offline, kernel don't know whether it'll come back. Sounds reasonable. > > > Looks good. Also, instead of array we can use single variable for > target_cpu_speed. I think yes. If one day the cores support rate changing independently, we can create another driver. It supposed to be another patch to do it. Thanks Richard -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html