On 12/19/2012 11:11 PM, Laxman Dewangan wrote: > On Wednesday 19 December 2012 10:32 PM, Stephen Warren wrote: >> On 12/19/2012 06:40 AM, Laxman Dewangan wrote: >>> The flag parameter is added in the cyclic transfer request. >>> Use the flag option of: >>> - DMA_PREP_INTERRUPT for enabling interrupt. >>> - DMA_CTRL_ACK for deciding whether ack is requred or not for >>> descriptor. >> Do the relevant drivers that use Tegra's DMA engine already set flags >> correctly, so that this change won't cause any regressions? >> > > Currently, the sound soc driver uses the cyclic mode of dma transfer and > it has already enable the proper flags. This was done recently after > adding flags in cyclic api. > Also, there was bug in our dma driver for not setting DMA_CTRL_ACK by > default for cyclic case. > This will fix the issue. OK. I assume "This was done recently after adding flags in cyclic api." was a patch that went into 3.8? So, this patch is a bug-fix that should be included in 3.8 then? -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html