Thank you for your comments, I will drop this patch. - Arto ________________________________________ From: Thierry Reding [thierry.reding@xxxxxxxxxxxxxxxxx] Sent: Friday, November 23, 2012 11:53 PM To: Terje Bergstrom Cc: linux-tegra@xxxxxxxxxxxxxxx; Arto Merilainen Subject: Re: [PATCH 4/6] gpu: drm: tegra: Free platform data on remove * PGP Signed by an unknown key On Thu, Nov 22, 2012 at 11:48:02AM +0200, Terje Bergstrom wrote: > From: Arto Merilainen <amerilainen@xxxxxxxxxx> > > Platform data was not freed in device removal. This patch adds > missing devm_kfree() calls. > > Change-Id: Id00fd1940e786dbc80c7ac5a1bd4d6a4c18720a1 > Signed-off-by: Arto Merilainen <amerilainen@xxxxxxxxxx> > Signed-off-by: Terje Bergstrom <tbergstrom@xxxxxxxxxx> > --- > drivers/gpu/drm/tegra/dc.c | 3 +++ > drivers/gpu/drm/tegra/dsi.c | 3 +++ > drivers/gpu/drm/tegra/hdmi.c | 3 +++ > drivers/gpu/drm/tegra/tvo.c | 3 +++ > 4 files changed, 12 insertions(+) All of this is unnecessary. The reason for using the managed allocations in the first place is because the memory is automatically freed when the device is removed. Thierry * Unknown Key * 0x7F3EB3A1 -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html