On Thu, Nov 22, 2012 at 01:16:51PM +0100, Terje Bergstrom wrote: > From: Arto Merilainen <amerilainen@xxxxxxxxxx> > <snip> > + > +int tegra_drm_unregister_client(struct tegra_drm_client *client) > +{ > + int ret = 0; > + > + list_for_each_entry(client, &tegra_drm_subdrv_list, list) { > + > + struct platform_device *pdev = to_platform_device(client->dev); > + > + if (client->ops && client->ops->drm_exit) { > + int err = client->ops->drm_exit(client); Shadow error variable err (ret is not used) > + if (err < 0) > + dev_dbg(client->dev, "drm_exit() failed for %s: %d\n", > + dev_name(client->dev), err); > + } > + > + /* if this is the last device, unregister the drm driver */ > + if (client->list.next == &tegra_drm_subdrv_list) > + drm_platform_exit(&tegra_drm_driver, pdev); > + > + list_del_init(&client->list); > + } > + > + return ret; > +} > + > +static int tegra_drm_load(struct drm_device *drm, unsigned long flags) > +{ > + struct tegra_drm_client *client; > + int err; > + > + drm_mode_config_init(drm); > + > + list_for_each_entry(client, &tegra_drm_subdrv_list, list) { > + if (client->ops && client->ops->drm_init) { > + int err = client->ops->drm_init(client, drm); Shadow variable -Sivaram -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html