Hi Alexandre,
The code looks neat, thanks for you work!
Just a couple of comments...
On Fri, Nov 16, 2012 at 03:38:21PM +0900, Alexandre Courbot wrote:
[...]
> +
> +#include "power_seq_delay.c"
> +#include "power_seq_regulator.c"
> +#include "power_seq_pwm.c"
> +#include "power_seq_gpio.c"
This is odd, although I remember you already explained why you have to
include the .c files, instead of linking them separately. But I forgot the
reason. :) I think this deserves a comment in the code.
> +static int of_power_seq_parse_step(struct device *dev,
> + struct device_node *node,
> + struct power_seq *seq,
> + unsigned int step_nbr,
> + struct list_head *resources)
> +{
> + struct power_seq_step *step = &seq->steps[step_nbr];
> + struct power_seq_resource res, *res2;
> + const char *type;
> + int i, err;
nit: one variable declaration per line.
Thanks,
Anton.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
