On 10/15/2012 02:07 PM, Stephen Warren wrote: > From: Stephen Warren <swarren@xxxxxxxxxx> > > Move Tegra's debug-macro.S over to the common debug macro directory. > > Move Tegra's debug UART selection menu into ARM's Kconfig.debug, so that > all related options are selected in the same place. > > Tegra's uncompress.h is left in mach-tegra/include/mach; it will be > removed whenever Tegra is converted to multi-platform. > > Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx> > --- > Rob, Arnd, Olof, I'd particularly like feedback on whether the following: > > #include "../../mach-tegra/iomap.h" > > in arch/arm/include/debug/tegra.S is acceptable. I'd really like to > continue to #include a header to share the defines to Tegra physical > memory layout and virtual based addresses with Tegra's io.c's struct > map_desc entries, so they can't get out of sync. So, the include can > either use the relative path as quoted above (which I don't think will > cause any significant maintenance issue), or Tegra's iomap.h would have > to be moved somewhere public so e.g. <tegra-iomap.h> could be included. We already have a way to get the phys and virt addresses at runtime with addruart macro. Couldn't we wrap this with a proper function and setup the mapping at runtime. This would move it out of the platforms. I'd also like to make the virtual address the same on all platforms (but different offsets within a 1MB section) and make the phys address a kconfig option. This would also eliminate the need for the platform include and potentially addruart for that matter. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
