On Wed, 2012-10-10 at 06:29 +0800, Stephen Warren wrote: > On 10/08/2012 04:26 AM, Joseph Lo wrote: > > LP2 is one of the Tegra low power states that supports power gating both > > CPU cores and GICs. Adding a resume function for taking care the CPUs that > > resume from LP2. This function was been hooked to reset handler. We take > > care everything here before go into kernel. > > > diff --git a/arch/arm/mach-tegra/headsmp.S b/arch/arm/mach-tegra/headsmp.S > > > +ENTRY(tegra_resume) > ... > > + /* Are we on Tegra20? */ > > + mov32 r6, TEGRA_APB_MISC_BASE > > + ldr r0, [r6, #APB_MISC_GP_HIDREV] > > + and r0, r0, #0xff00 > > + cmp r0, #(0x20 << 8) > > + beq 1f > > +#ifdef CONFIG_ARCH_TEGRA_3x_SOC > > + /* Clear the flow controller flags for this CPU. */ > > + mov32 r2, TEGRA_FLOW_CTRL_BASE + FLOW_CTRL_CPU0_CSR @ CPU0 CSR > > + ldr r1, [r2] > > + /* Clear event & intr flag */ > > + orr r1, r1, \ > > + #FLOW_CTRL_CSR_INTR_FLAG | FLOW_CTRL_CSR_EVENT_FLAG > > + movw r0, #0x0FFD @ enable, cluster_switch, immed, & bitmaps > > + bic r1, r1, r0 > > + str r1, [r2] > > +#endif > > +1: > > couldn't that entire quoted chunk go inside the ifdef; all of reading > the HIDREV register and the 1: label? Ah. Yes, it's OK. Will do. Thanks, Joseph -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html