On Tue, Oct 02, 2012 at 01:07:44PM -0600, Stephen Warren wrote:
[...]
> choice
> - prompt "Default low-level debug console UART"
> - default TEGRA_DEBUG_UART_NONE
> + prompt "Low-level debug console UART"
> + default TEGRA_DEBUG_UART_AUTO_ODMDATA
>
> -config TEGRA_DEBUG_UART_NONE
> - bool "None"
> +config TEGRA_DEBUG_UART_AUTO_ODMDATA
The first item in a list of choices is automatically selected as the
default, so technically the default is redundant here. I suppose it
doesn't hurt to be explicit.
> diff --git a/arch/arm/mach-tegra/common.c b/arch/arm/mach-tegra/common.c
> index 0b0a5f5..0913d1f 100644
> --- a/arch/arm/mach-tegra/common.c
> +++ b/arch/arm/mach-tegra/common.c
> @@ -44,14 +44,13 @@
> * kernel is loaded. The data is declared here rather than debug-macro.S so
> * that multiple inclusions of debug-macro.S point at the same data.
> */
> -#define TEGRA_DEBUG_UART_OFFSET (TEGRA_DEBUG_UART_BASE & 0xFFFF)
> u32 tegra_uart_config[3] = {
> /* Debug UART initialization required */
> 1,
> /* Debug UART physical address */
> - (u32)(IO_APB_PHYS + TEGRA_DEBUG_UART_OFFSET),
> + 0,
> /* Debug UART virtual address */
> - (u32)(IO_APB_VIRT + TEGRA_DEBUG_UART_OFFSET),
> + 0,
> };
I don't quite see how this is supposed to work now. Won't the debug.S
code fail if these fields are set to 0?
Thierry
Attachment:
pgpnRvjyK6jGg.pgp
Description: PGP signature
