You'll want to check that you don't have any cases where two files use the same guard, I'd think. Chris -----Original Message----- From: linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Arnd Bergmann Sent: September 11, 2012 10:06 AM To: Chris Ball Cc: Mark Brown; Russell King; Stephen Warren; Dmitry Torokhov; linux-kernel@xxxxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; Colin Cross; Olof Johansson; Liam Girdwood; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH 09/16] ARM: tegra: move platform_data definitions On Tuesday 11 September 2012, Chris Ball wrote: > On Tue, Sep 11 2012, Arnd Bergmann wrote: > > diff --git a/arch/arm/mach-tegra/include/mach/sdhci.h > > b/include/linux/platform_data/mmc-sdhci-tegra.h > > similarity index 100% > > rename from arch/arm/mach-tegra/include/mach/sdhci.h > > rename to include/linux/platform_data/mmc-sdhci-tegra.h > > Looks like you aren't renaming the idempotency guards, so e.g. > include/linux/platform_data/mmc-sdhci-tegra.h will contain: > > #ifndef __ASM_ARM_ARCH_TEGRA_SDHCI_H > #define __ASM_ARM_ARCH_TEGRA_SDHCI_H > > Is that intentional? Thanks, > No, it's not intentional. We actually have a lot of instances that are already wrong. Do we care enough to change the ones I'm moving here? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
