Re: [PATCH 2/2] ARM: dt: tegra: harmony: add regulators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 28 August 2012 12:40 PM, Stephen Warren wrote:
  #include "board.h"
-#include "board-harmony.h"

  #ifdef CONFIG_TEGRA_PCI

  int __init harmony_pcie_init(void)
  {
-       struct regulator *regulator = NULL;
+       struct regulator *regulator_1v5, *regulator_pex;
         int err;

-       err = gpio_request(TEGRA_GPIO_EN_VDD_1V05_GPIO, "EN_VDD_1V05");
-       if (err)
-               return err;
+       regulator_1v5 = regulator_get(NULL, "vdd_1v5");
+       if (IS_ERR_OR_NULL(regulator_1v5)) {
+               err = PTR_ERR(regulator_1v5);
+               goto err_reg;
+       }

You need to return in case of err otherwise it will cause the crash in regulator_disable() with NULL argument.


--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux