On Wed, Aug 15, 2012 at 08:40:08AM +0300, Hiroshi Doyu wrote: > On Thu, 9 Aug 2012 14:56:24 +0200 > Hiroshi Doyu <hdoyu@xxxxxxxxxx> wrote: > > > Hi Greg, Felipe, > > > > On Wed, 8 Aug 2012 15:34:27 +0200 > > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > On Wed, Aug 08, 2012 at 09:24:32AM +0300, Hiroshi Doyu wrote: > > > > Add __debugfs_create_dir(), which takes data passed from caller. > > > > > > Why? > > > > > > > Signed-off-by: Hiroshi Doyu <hdoyu@xxxxxxxxxx> > > > > --- > > > > fs/debugfs/inode.c | 7 ++++--- > > > > include/linux/debugfs.h | 9 ++++++++- > > > > 2 files changed, 12 insertions(+), 4 deletions(-) > > ..... > > > What are you trying to do here? This patch doesn't look right at all. > > > > I missed to send the cover letter of this patch series to LKML, which > > explained the background. I attached that cover letter below. Please > > read the following explanation too. > > Any chance to get some feedback on this? I still don't like it, and then there's the basic fact that I'm pretty sure you broke the build with the patch, but who's noticing little things like that :) > I'm also sending another version of patch, which just uses > debgufs_create_dir() as Felipe suggested, in-reply-to this mail. I'd prefer not to change debugfs for this, so if you don't do that, I don't object to your driver-specific patch. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
