On Thu, Jul 26, 2012 at 12:55 PM, Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> wrote: > When using deferred driver probing, PCI host controller drivers may > actually require this function after the init stage. Yes, this is a bug. Actually, there's still another bug here: if we hot-add a device, we won't do pdev_fixup_irq() for it. But your change is worthwhile even without fixing that other bug. Normally I would include this in my PCI tree since it's under drivers/pci. That would make it easier for somebody to fix the hotplug problem in this cycle. Would having it in my PCI tree make things harder for you? > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > --- > Changes in v3: > - none > > Changes in v2: > - use __devinit annotations > > drivers/pci/setup-irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c > index eb219a1..f0bcd56 100644 > --- a/drivers/pci/setup-irq.c > +++ b/drivers/pci/setup-irq.c > @@ -18,7 +18,7 @@ > #include <linux/cache.h> > > > -static void __init > +static void __devinit > pdev_fixup_irq(struct pci_dev *dev, > u8 (*swizzle)(struct pci_dev *, u8 *), > int (*map_irq)(const struct pci_dev *, u8, u8)) > @@ -54,7 +54,7 @@ pdev_fixup_irq(struct pci_dev *dev, > pcibios_update_irq(dev, irq); > } > > -void __init > +void __devinit > pci_fixup_irqs(u8 (*swizzle)(struct pci_dev *, u8 *), > int (*map_irq)(const struct pci_dev *, u8, u8)) > { > -- > 1.7.11.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html