Hi, On Wed, Aug 08, 2012 at 09:24:33AM +0300, Hiroshi Doyu wrote: > The commit c3b1a35 "debugfs: make sure that debugfs_create_file() gets > used only for regulars" doesn't allow to use debugfs_create_file() for > dir. Use the version with "data", __debugfs_create_dir(). > > Signed-off-by: Hiroshi Doyu <hdoyu@xxxxxxxxxx> > Reported-by: Laxman Dewangan <ldewangan@xxxxxxxxxx> > --- > drivers/iommu/tegra-smmu.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c > index 5e51fb7..41aff7a 100644 > --- a/drivers/iommu/tegra-smmu.c > +++ b/drivers/iommu/tegra-smmu.c > @@ -1035,9 +1035,7 @@ static void smmu_debugfs_create(struct smmu_device *smmu) > int i; > struct dentry *root; > > - root = debugfs_create_file(dev_name(smmu->dev), > - S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO, > - NULL, smmu, NULL); > + root = __debugfs_create_dir(dev_name(smmu->dev), NULL, smmu); why would the directory need extra data ? Looking in mainline, tegra-smmu.c doesn't have any debugfs support, where can I see the patches adding debugfs to tegra-smmu ? It doesn't look correct that the directory will have a data field. -- balbi
Attachment:
signature.asc
Description: Digital signature
