Am Donnerstag, 5. Juli 2012, 11:18:14 schrieb Wei Ni: > On Wed, 2012-07-04 at 19:51 +0800, Marc Dietrich wrote: > > Am Mittwoch, 4. Juli 2012, 19:23:33 schrieb Wei Ni: > > > On Wed, 2012-07-04 at 18:43 +0800, Marc Dietrich wrote: > > > > Am Mittwoch, 4. Juli 2012, 17:34:44 schrieb Wei Ni: > > > > > Set up the wlan clock tree for Tegra20 and Tegra30. > > > > > > > > > > Signed-off-by: Wei Ni <wni@xxxxxxxxxx> > > > > > --- > > > > > > > > > > arch/arm/mach-tegra/board-dt-tegra20.c | 1 + > > > > > arch/arm/mach-tegra/board-dt-tegra30.c | 1 + > > > > > 2 files changed, 2 insertions(+), 0 deletions(-) > > > > > > > > > > diff --git a/arch/arm/mach-tegra/board-dt-tegra20.c > > > > > b/arch/arm/mach-tegra/board-dt-tegra20.c index 70a19a9..fbcc7d9 > > > > > 100644 > > > > > --- a/arch/arm/mach-tegra/board-dt-tegra20.c > > > > > +++ b/arch/arm/mach-tegra/board-dt-tegra20.c > > > > > @@ -78,6 +78,7 @@ static __initdata struct tegra_clk_init_table > > > > > tegra_dt_clk_init_table[] = { { "pll_a", "pll_p_out1", > > > > > 56448000, > > > > > > > > > > true }, > > > > > > > > > > { "pll_a_out0", "pll_a", 11289600, true }, > > > > > { "cdev1", NULL, 0, true }, > > > > > > > > > > + { "blink", "clk_32k", 32768, true }, > > > > > > > > what's the reason to enable this on all boards? Would it make sense to > > > > set > > > > this to "false" instead? > > > > > > This clock is used for the wlan device, it need to be enabled, so that > > > the wlan device can be powered on, and then the mmc driver can enumerate > > > it. > > ... > Yes we have thought about this issue. > In here we need to enable this clock before loading wifi driver, so that > the mmc driver can enumerate it. > This likes another thing that the SD controller should be taught how to > provide to clients, such as trigger the power/reset gpios. We had talked > about it in the: > http://www.spinics.net/lists/linux-wireless/msg92093.html ah, sorry, I didn't followed this discussion. > And we are trying to provide the tegra clk framework support, so at that > time we could set this clock for different boards. > > So I suppose we can just dump it into the clk init tables for now. ok, thanks for explanation. Let's hope there will be a better solution in the future. Thanks! Marc -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html