On Thu, Jul 05, 2012 at 11:36:48AM +0900, Alex Courbot wrote: > On 07/05/2012 12:24 AM, Mark Brown wrote: > >On Thu, Jul 05, 2012 at 12:14:39AM +0900, Alex Courbot wrote: > >>On Wed 04 Jul 2012 10:00:56 PM JST, Sascha Hauer wrote: > > > >>>Also please be aware that using a regulator in the pwm backlight will > >>>instantly break all existing users. That's hardly your fault though. > > > >>Sorry, I don't see why. Could you elaborate on this? > > > >All existing machines will start failing during probe as they won't be > >able to find the regulator - you should ideally make sure everyone in > >mainline gets an appropriate regulator set up. > > Oh, that is a mistake of mine then. Driver probe should continue if > no regulator is declared (but should fail if some other error > occured). I want to maintain backward compatibility with current > users of the driver, so regulator/gpio specification should be > optional. I think the only way doing this is to add a flag to platform_data. I don't know if that's accepted though. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
