Re: tegra alloc_pdir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

Chris Wright <chrisw@xxxxxxxxxxxx> wrote @ Tue, 26 Jun 2012 20:15:55 +0200:

> This looks buggy to me:
> 
> drivers/iommu/tegra-smmu.c::smmu_iommu_domain_init()
> 
>   spin_lock_irqsave(&tmp->lock, flags);   <-- lock held, interrupts off
>   alloc_pdir(as = tmp)
>     devm_kzalloc(..., GFP_KERNEL);        <-- potentially sleeping allocation
>     ...
>     alloc_page(..., GFP_KERNEL | __GFP_DMA);   <-- same here

Right. I totally agree. Thank you for pointing this out.

The fix patch follows.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux