Hi Olof, On Wed, 16 May 2012 08:35:02 +0200 Olof Johansson <olof@xxxxxxxxx> wrote: > Hi, > > Tiny drive-by nit pick. > > On Thu, May 10, 2012 at 12:42 AM, Hiroshi DOYU <hdoyu@xxxxxxxxxx> wrote: > > Add Tegra MC(Memory Controller) nodes for tegra20.dtsi. > > > > Signed-off-by: Hiroshi DOYU <hdoyu@xxxxxxxxxx> > > --- > > arch/arm/boot/dts/tegra20.dtsi | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > > index 24129fb..548b42e 100644 > > --- a/arch/arm/boot/dts/tegra20.dtsi > > +++ b/arch/arm/boot/dts/tegra20.dtsi > > @@ -211,5 +211,12 @@ > > compatible = "nvidia,tegra20-ahb"; > > reg = <0x6000c004 0x10c>; /* AHB Arbitration + Gizmo Controller */ > > }; > > + > > + mc { > > It's common to use a more plain english name here, so > "memory-controller" would be a good name. Agree. Seems to be common as below. Fix patches follows, which can be squashed if possible. $% grep memory-controller arch/arm/boot/dts/* arch/arm/boot/dts/prima2-cb.dts: memory-controller@90000000 { arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts: memory-controller@2b0a0000 { arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts: memory-controller@7ffd0000 { arch/arm/boot/dts/vexpress-v2p-ca5s.dts: memory-controller@2a150000 { arch/arm/boot/dts/vexpress-v2p-ca5s.dts: memory-controller@2a190000 { arch/arm/boot/dts/vexpress-v2p-ca9.dts: memory-controller@100e0000 { arch/arm/boot/dts/vexpress-v2p-ca9.dts: memory-controller@100e1000 { -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html