Stephen Warren <swarren@xxxxxxxxxxxxx> wrote @ Tue, 15 May 2012 01:34:15 +0200: > On 05/14/2012 01:16 PM, Hiroshi DOYU wrote: > > To simplify the code, alloc necessary data at once. > > > > Signed-off-by: Hiroshi DOYU <hdoyu@xxxxxxxxxx> > > --- > > This patch requires: > > > > [PATCH 1/2] iommu/tegra: smmu: Add device tree support for SMMU > > http://marc.info/?l=linux-tegra&m=133663641107327&w=2 > > > > Also the above patch requires: > > > > [PATCH 1/1] dt: Add general DMA window parser > > http://marc.info/?l=linux-tegra&m=133671302703840&w=2 > > I know I've been harping on about dependencies, but you typically only > need to mention them if the dependencies are not already checked into > the branch you expect this patch to be checked into. > > > - smmu = devm_kzalloc(dev, sizeof(*smmu), GFP_KERNEL); > > + if (of_property_read_u32(dev->of_node, "nvidia,#asids", &asids)) > > + return -ENODEV; > > I believe you need to change the asids variable from int to u32 to avoid > a warning here. There's no warning but it's allowed because of "-Wno-pointer-sign". It seems that this flag has been used for long in kernel, and there are many places. Is this conversion allowed because it's expeced that the author should know the range of value, or any other reason? *1: -Wno-pointer-sign Don't warn for pointer argument passing or assignment with different signedness. Only useful in the negative form since this warning is enabled by default. This option is only supported for C and Objective-C. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
