On Tue, May 08, 2012 at 05:04:42PM +0100, Alan Cox wrote: > On Tue, 08 May 2012 09:46:51 -0600 > Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > > > On 05/08/2012 03:35 AM, Alan Cox wrote: > > > On Mon, 07 May 2012 17:06:38 -0600 > > > Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > > > > > >> Alan, > > >> > > >> Commit d29f3ef "tty_lock: Localise the lock" appears to cause a > > >> problem for me. > > >> > > >> With this commit (as in next-20120507), I can no longer log into my > > >> system (NVIDIA Tegra device with ARM CPU) over the serial console, > > >> since the login prompt no longer appears. If I wait a few minutes, > > >> I see the following console spew: > > > > > > Eep. If it's reproducable can you test whether adding the > > > unlock/relock in drivers/tty/pty.c does the trick ? > > > > > > ie: > > > tty_unlock(tty); > > > tty_vhangup(tty); > > > tty_lock(tty); > > > > Yes, that change in pty_close() solves the problem. > > Ok Greg - I think we should go with putting that unlock back until we > understand exactly what is going on. Ok, care to send a patch that does this so I get it correct, and we get a reported-by from Stephen? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html