Am Sonntag, 29. April 2012, 13:16:38 schrieb Stephen Warren: > On 04/29/2012 12:11 PM, Marc Dietrich wrote: > > On Saturday 28 April 2012 22:34:56 Russell King - ARM Linux wrote: > >> On Sat, Apr 28, 2012 at 06:09:32PM +0200, Marc Dietrich wrote: > >>> Another (maybe a bit off-topic) thing that puzzels me is the how to > >>> assign > >>> the clock to the nvec. > >> > >> What's the nvec? > > > > it is the embedded controller used on many first gen tegra2 boards > > (drivers/staging/nvec). Do you remember commit 55dc6ee7 ? > > > >>> The device needs the clock (tegra-i2c.2) but there is no sane way to get > >>> it. I was thinking to add an device name alias (nvec = tegra-i2c.2) to > >>> the board file so I can use clk_get(&pdev->dev, NULL) instead of > >>> clk_get_sys which seems to be unwanted. > >> > >> clk_get() is preferred in drivers which have struct device's to get them. > >> And if you know the device name, then I see no problem with the aliasing > >> approach. > > > > I'm just looking for a way to use clk_get if two devices, tegra-i2c and > > nvec (or tegra-i2c-slave in the future) share the same clock. > > Oh, you mean the I2C controller clock. > > The correct approach here is to remove all the I2C logic from the NVEC > driver and add I2C slave support to the real I2C driver. Then, NVEC > becomes just a protocol driver for the slave transactions. Then, there > is no clock to deal with. you are absolutely right, but there is no i2c slave controller driver in mainline yet and I don't want to submit the one nvidia already wrote [1]. Maybe you can ask around if someone is willing to do this. Anyway, removal of the board files will not make it worser than it is already so this is not a show stopper. Marc [1] http://nv- tegra.nvidia.com/gitweb/?p=linux-2.6.git;a=blob;f=drivers/i2c/busses/i2c- slave-tegra.c;hb=linux-tegra-nv-3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
