On Wed, 18 Apr 2012 21:39:45 +0200 Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> wrote: > * PGP Signed by an unknown key > > * Stephen Warren wrote: > > On 04/18/2012 04:19 AM, Hiroshi Doyu wrote: > > > > > Subject: [PATCH 1/1] dt: Add general DMA window parser > > > > > > This code was stolen from: > > > "arch/microblaze/kernel/prom_parse.c" > > > "arch/powerpc/kernel/prom_parse.c" > > > > > > Once "ibm," prefix is removed from dts file. This generic one could > > > replace the originals. > > > > > +extern void of_parse_dma_window(struct device_node *dn, > > > + const void *dma_window_prop, unsigned long *busno, > > > + unsigned long *phys, unsigned long *size); > > > > At least some other of_*() parsing functions take the property name > > rather than the property pointer, and also take an index into the > > property in order to support multiple entries in it. See for example > > of_parse_phandle and of_get_named_gpio_flags. Should this new API be > > similar? E.g.: > > > > extern void of_parse_dma_window(struct device_node *np, > > const char *propname, int index, > > unsigned long *busno, > > unsigned long *phys, unsigned long *size); > > In that case the function should return int for proper error handling. Good point. I'll. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
