Re: [PATCH 1/1] dt: Add general DMA window parser

[Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>]

* Hiroshi Doyu wrote:
> +	cells = prop ? *(__be32 *)prop : of_n_addr_cells(dn);

I think this needs to be:

	cells = prop ? be32_to_cpup(prop) : of_n_addr_cells(dn);

Only casting isn't enough, you need the bytes to be swapped.

> +	cells = prop ? *(__be32 *)prop : of_n_size_cells(dn);

Similarly:

	cells = prop ? be32_to_cpup(prop) : of_n_size_cells(dn);

Thierry

Attachment: pgpxHs6hLxJEC.pgp
Description: PGP signature