Re: [PATCH v5 01/16] pwm: Add PWM framework support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Shawn Guo wrote:
> A couple of trivial editorial errors, otherwise,
> 
> Reviewed-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> 
> On Wed, Mar 28, 2012 at 04:33:43PM +0200, Thierry Reding wrote:
> > From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > 
> > This patch adds framework support for PWM (pulse width modulation) devices.
> > 
> > The is a barebone PWM API already in the kernel under include/linux/pwm.h,
> 
> s/The/There
> 
> > but it does not allow for multiple drivers as each of them implements the
> > pwm_*() functions.
> > 
> ...
> 
> > +/**
> > + * pwm_request() - request a PWM device
> > + * @pwm: global PWM device index
> 
> s/pwm/pwm_id
> 
> > + * @label: PWM device label
> > + */
> > +struct pwm_device *pwm_request(int pwm_id, const char *label)
> ...
> 
> > +/**
> > + * struct pwm_chip - abstract a PWM
> > + * @label: for diagnostics
> > + * @owner: helps prevent removal of modules exporting active PWMs
> 
> The doc needs an update.

Thanks,
Thierry

Attachment: pgps9aOgzC9ft.pgp
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux