Re: [PATCH v5 09/16] pwm: tegra: Add device tree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Stephen Warren wrote:
> On 03/28/2012 08:33 AM, Thierry Reding wrote:
> > Add auxdata to instantiate the PWFM controller from a device tree,
> > include the corresponding nodes in the dtsi files for Tegra 20 and
> > Tegra 30 and add binding documentation.
> > 
> > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
> > Acked-by: Stephen Warren <swarren@xxxxxxxxxxxxx>
> 
> > diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c
> ...
> > +#ifdef CONFIG_OF
> > +static struct of_device_id tegra_pwm_of_match[] = {
> > +	{ .compatible = "nvidia,tegra20-pwm" },
> > +	{ .compatible = "nvidia,tegra30-pwm" },
> 
> Could you swap those two lines, so that tegra30-pwm matches first. It
> makes no difference at present, but might in the future if the driver
> actually has to differentiate the two SoCs.

I thought the matching order was determined by the compatible property in the
device tree, not the OF match table of the driver.

Thierry

Attachment: pgp873k0WOjsN.pgp
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux