Re: [PATCH 12/17] ASoC: tegra: utils: add support for Tegra30 devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 30, 2012 at 05:07:27PM -0600, Stephen Warren wrote:

> -	ret = tegra_asoc_utils_init(&alc5632->util_data, &pdev->dev);
> +	ret = tegra_asoc_utils_init(&alc5632->util_data,
> +				    TEGRA_ASOC_UTILS_SOC_TEGRA20, &pdev->dev);

Would it not be more sensible to do cpu_is_() calls in the utils code
rather than have the board say?  It'd possibly also end up looking nicer
in the code and may mean the compiler can figure out not to include
cases that can't be taken in the current build.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux