* Stephen Warren wrote: > On 03/14/2012 09:56 AM, Thierry Reding wrote: > > From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > > > This patch adds framework support for PWM (pulse width modulation) devices. > ... > > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c > ... > > +/** > > + * pwmchip_add() - register a new pwm > > + * @chip: the pwm > > + * > > + * register a new pwm. pwm->pwm_id must be initialized. if pwm_id < 0 then > > + * a dynamically assigned id will be used, otherwise the id specified, > > + */ > > I don't see anywhere in the code that implements "if pwm_id < 0 then a > dynamically assigned id will be used". The second patch in the series fixes up this comment when the functionality is properly implemented. I still wanted to go over the first patch and fix up some minor things, so maybe I'll fix this up as I go along. Thierry
Attachment:
pgpI_dCwmegd2.pgp
Description: PGP signature