Hi Stephen, On Wed, Mar 7, 2012 at 12:46 PM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > On 03/06/2012 10:00 PM, Simon Glass wrote: >> From: Yen Lin <yelin@xxxxxxxxxx> >> >> Add basic i2c driver for Tegra2 with 8- and 16-bit address support. >> The driver requires CONFIG_OF_CONTROL to obtain its configuration >> from the device tree. >> >> (Simon Glass: sjg@xxxxxxxxxxxx modified for upstream) >> >> Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx> > > I'm not sure whether i2c_init_board() correctly detects I2C bus ID > assignment conflicts between nodes with the "-i2c" and "-i2c-dvc" > compatible values, but I think that only affects cases where the .dts > file is already wrong, so it's probably not a big deal. That logic is in fdtdec, and at some point in the various series I do add a check for this. > > Aside from that, I did a very very brief review. So, > > Acked-by: Stephen Warren <swarren@xxxxxxxxxxxxx> Thanks. Regards, Simon -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
