Hi Stephen, On Tue, Feb 28, 2012 at 10:47 AM, Stephen Warren <swarren@xxxxxxxxxx> wrote: > Simon Glass wrote at Tuesday, February 28, 2012 11:08 AM: >> Add the definition of the oscillator clock frequency and the 32KHz clock. >> The latter is provided by a PMIC on I2C which we don't actually use at >> present, but we expect this definition to be used in the kernel and want >> to keep our .dts the same. >> >> Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx> > > Sigh. > > I suppose I can ack this, only because it's U-Boot and not the kernel > so I care a little less about making sure it's correct. > > Acked-by: Stephen Warren <swarren@xxxxxxxxxx> > > Please let it be noted that I do object to: > * Using an undefined/undocumented binding for the tps6586x. > * Not including the required properties for #clock-cells in both clock > nodes, and not including the compatible value in the osc node. Once you have this in Linux please point me to the commit and I will do an update. Re the # issue I will take a look in the next few weeks. Regards, Simon > > I'm aware that U-Boot's current code-base isn't influenced by these issues, > but this kind of thing is pretty much on the same level as BIOS vendors > only caring about Windows working on their HW and not other OSs. > > I hope this doesn't come back and bite me, e.g. someone using this as an > example for kernel work. > > -- > nvpublic > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
