Hi Stephen, On Mon, Feb 27, 2012 at 3:29 PM, Stephen Warren <swarren@xxxxxxxxxx> wrote: > On 02/27/2012 01:52 PM, Simon Glass wrote: >> Add the definition of the oscillator clock frequency. > >> diff --git a/board/nvidia/dts/tegra2-seaboard.dts b/board/nvidia/dts/tegra2-seaboard.dts > >> + clock@60006000 { >> + clocks = <&osc>; >> + }; > > The CAR takes two clock inputs; one 32KHz clock (typically from the > PMU/PMIC) and one from the oscillator. The 32KHz one is missing here. I > guess this won't make any difference to U-Boot since it isn't using the > clock inputs in the CAR driver, but it'd be best if the .dts file > contained the correct content so it didn't act as an incorrect example. > See the example in the binding documentation for what should be there. Yes I saw that - but it adds an i2c binding which I don't yet have. I add i2c in the next series. I will add that one i2c node here. Regards, Simon > > -- > nvpublic > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html