On Fri, Feb 17, 2012 at 08:16:05PM +0100, Thierry Reding wrote: > * Mark Brown wrote: > > This is a bit weird, why is this not just set by constraints? > I guess because I didn't know any better. I don't have access to the hardware > right now, so it'll have to wait until Monday. I'll follow up with a patch > after I've verified that setting via constraints works. OK. In general the expected idiom is that drivers will only use set_voltage() if they actually need to change the voltage at runtime, if they just need a single fixed voltage then the expectation is that either the board will boot in the correct configuration or the setup will be done by constraints. This replaces code with data (which is generally a good thing) and avoids issues with things like error handling when working with fixed voltage regulators.
Attachment:
signature.asc
Description: Digital signature
