On Mon, Feb 13, 2012 at 10:18 PM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote: > Linus mentioned that this should be part of pinctrl instead of the gpio API, > but I think there is an argument for making it part of the gpio API, > particularly since open-drain is pretty much a universal concept that all > gpio controllers can support (unlike driver strength) Actually pinctrl is engineered to be used as back-end for gpiolib so thinking about it I'm pretty happy with this arrangement, the gpiolib driver can very well call down to pinctrl to have the actual setting done if needed. So it's no big deal. It is also a case for making some of the pin config business generic, which I have failed at in the past. > Have you though about support for lines that are pulled low instead of > high? Those aren't as common, but it is conceivable that some > hardware would need it. So if the idea is (if I get it correctly) that this thing is an input sometimes and open drain/collector output sometimes, then open source/emitter for the inverse situation is an equally valid case right? In that case I think it'd be best to add both. The COH901 driver for U300 supports open source/emitter BTW. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html