On Fri, Feb 10, 2012 at 09:30:28PM +0530, Laxman Dewangan wrote:
> + /* No formatting is require if val_byte is 1 */
> + if (val_bytes == 1)
> + wval = (void *)val;
> + else {
Please don't combine branches with and without braces.
> + wval = kmemdup(val, val_count * val_bytes, GFP_KERNEL);
> + if (!wval) {
> + mutex_unlock(&map->lock);
> + dev_err(map->dev,
> + "Error in memory allocation\n");
> + return -ENOMEM;
As a style thing a goto error pattern is clearer for stuff like this -
there's so many branches that it's complex to keep track of the
unwinding.
Attachment:
signature.asc
Description: Digital signature
