On Tue, Jan 31, 2012 at 9:45 AM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:
> The device tps65910/tps65911 supports the sleep
> functionality in some of gpios. If gpio is configured
> in output mode and sleep is enabled then during device
> sleep state, the output of gpio becomes LOW regardless
> of non-sleep output value.
> Such gpio can be used to control regulator switch such
> that output of regulator is off in device sleep state.
>
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
Strictly speaking this is pin control business, but since it is already
doing other stuff like this from platform data why not...
Comments:
> diff --git a/include/linux/mfd/tps65910.h b/include/linux/mfd/tps65910.h
> index fa6c6bf..b641690 100644
> --- a/include/linux/mfd/tps65910.h
> +++ b/include/linux/mfd/tps65910.h
> @@ -657,6 +657,8 @@
>
>
> /*Register GPIO (0x80) register.RegisterDescription */
> +#define GPIO_SLEEP_MASK 0x80
> +#define GPIO_SLEEP_SHIFT 7
> #define GPIO_DEB_MASK 0x10
> #define GPIO_DEB_SHIFT 4
> #define GPIO_PUEN_MASK 0x08
> @@ -740,6 +742,9 @@
> #define TPS65910_GPIO_STS BIT(1)
> #define TPS65910_GPIO_SET BIT(0)
>
> +/* Max number of TPS65910/11 GPIOs */
> +#define TPS65911_NUM_GPIO 9
Then name it TPS_6591X_MAX_NUM_GPIO
I would write:
#define TPS65910_NUM_GPIO 6
#define TPS65911_NUM_GPIO 9
#define TPS6591X_MAX_NUM_GPIO 9
And then also refactor this code in the driver:
switch(tps65910_chip_id(tps65910)) {
case TPS65910:
tps65910->gpio.ngpio = 6;
break;
case TPS65911:
tps65910->gpio.ngpio = 9;
break;
default:
return;
to use the new defines instead of magic numbers while
you're at it.
> +
> /* Regulator Index Definitions */
> #define TPS65910_REG_VRTC 0
> #define TPS65910_REG_VIO 1
> @@ -786,6 +791,7 @@ struct tps65910_board {
> int irq_base;
> int vmbch_threshold;
> int vmbch2_threshold;
> + int en_gpio_sleep[TPS65911_NUM_GPIO];
This is used as a bool so use bool.
> unsigned long regulator_ext_sleep_control[TPS65910_NUM_REGS];
> struct regulator_init_data *tps65910_pmic_init_data[TPS65910_NUM_REGS];
> };
> --
> 1.7.1.1
Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
