> On Wednesday, January 18, 2012 11:26 PM, Mark Brown wrote: > > > > + .table_len = 73, > > > }, > > > Forgive me if these comments are bogus since I'm not familiar with > > regulators much, but: > > > a) Don't you want to use ARRAY_SIZE() instead of hard-coding table_len's > > value? > > > b) Don't you need to set .table to actually point at the table too? If not, > > isn't tps65910_list_voltage() going to dereference a NULL pointer, since > > it will dereference .table if .table_len is set? > > It's not actually a table at all any more as the driver calculates the > values, table_len is misnamed and should be renamed as well as set. Do you want to rename the variable in this patch or in separate patch? In place of table_len, I will say n_voltages as this is most common name in regulator world. > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
