Dmitry Torokhov wrote at Tuesday, December 27, 2011 11:49 PM: > On Tue, Dec 27, 2011 at 10:19:29PM -0800, Olof Johansson wrote: > > This adds a simple device tree binding to the tegra keyboard controller. ... > > + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); > > Error handling is missing. I also dislike devm_* facilities as it causes > inconsistencies in the way we handle releasing of resources: some of > them will be released automatically while others need t be released > manually. I prefer having consistent model. I have to say that I also disagree here. Weren't the devm_* function specifically added to allow people not to write all the error-handling code themselves. Forcing everyone not to use them doesn't seem right. There have been a ton of patches throughout the kernel converting drivers to use devm_* and at the same time removing and simplifying error handling. -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
